Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 841903002: Form labels not being spoken in TalkBack (Closed)

Created:
5 years, 11 months ago by ramya.v
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Form labels not being spoken in TalkBack BUG=380901 Committed: https://crrev.com/226a239b38a1f1fc3bc9bec8018334abafb5dc37 Cr-Commit-Position: refs/heads/master@{#310555}

Patch Set 1 #

Patch Set 2 : Updating test results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M content/browser/accessibility/browser_accessibility_android.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/test/data/accessibility/html/fieldset-expected-android.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/input-text-value-expected-android.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/legend-expected-android.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ramya.v
PTAL! Thanks
5 years, 11 months ago (2015-01-08 08:58:37 UTC) #2
dmazzoni
lgtm
5 years, 11 months ago (2015-01-08 18:09:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841903002/20001
5 years, 11 months ago (2015-01-08 18:10:52 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-08 19:12:01 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 19:14:01 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/226a239b38a1f1fc3bc9bec8018334abafb5dc37
Cr-Commit-Position: refs/heads/master@{#310555}

Powered by Google App Engine
This is Rietveld 408576698