Issue 841873007: rebase + ignores

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 841873007: rebase + ignores (Closed)

Created:
5 years, 11 months ago by joshua.litt

Modified:
5 years, 11 months ago

Reviewers:
joshualitt, djsollen

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -40 lines)			Patch
M	expectations/gm/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json	View	38 chunks	+38 lines, -38 lines	0 comments	Download
M	expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841873007/1

5 years, 11 months ago (2015-01-14 02:53:53 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/812c0283b9f9f1b795557f1ee76ae46ce0585d5d

5 years, 11 months ago (2015-01-14 02:54:05 UTC) #3

djsollen

5 years, 11 months ago (2015-01-14 14:47:44 UTC) #5

Message was sent while issue was closed.

I think you missed Test-Win8-ShuttleA-GTX660-x86-Debug as
shadertext_nvprmsaa4.png is causing that bot to fail the compare_gm step