Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: remoting/protocol/client_control_dispatcher.cc

Issue 841773005: Cleanup channel dispatchers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/client_control_dispatcher.h ('k') | remoting/protocol/client_event_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/client_control_dispatcher.cc
diff --git a/remoting/protocol/client_control_dispatcher.cc b/remoting/protocol/client_control_dispatcher.cc
index f08e6cfca71e8f41d5c5dd57c36b7c69b57636c2..d13e53fe008d2870e39f4a4a4b1e4552f88f1bc9 100644
--- a/remoting/protocol/client_control_dispatcher.cc
+++ b/remoting/protocol/client_control_dispatcher.cc
@@ -61,69 +61,65 @@ bool CursorShapeIsValid(const CursorShapeInfo& cursor_shape) {
ClientControlDispatcher::ClientControlDispatcher()
: ChannelDispatcherBase(kControlChannelName),
client_stub_(nullptr),
- clipboard_stub_(nullptr) {
+ clipboard_stub_(nullptr),
+ parser_(base::Bind(&ClientControlDispatcher::OnMessageReceived,
+ base::Unretained(this)),
+ reader()) {
}
ClientControlDispatcher::~ClientControlDispatcher() {
- writer_.Close();
-}
-
-void ClientControlDispatcher::OnInitialized() {
- // TODO(garykac): Set write failed callback.
- writer_.Init(channel(), BufferedSocketWriter::WriteFailedCallback());
- reader_.Init(channel(), base::Bind(
- &ClientControlDispatcher::OnMessageReceived, base::Unretained(this)));
}
void ClientControlDispatcher::InjectClipboardEvent(
const ClipboardEvent& event) {
ControlMessage message;
message.mutable_clipboard_event()->CopyFrom(event);
- writer_.Write(SerializeAndFrameMessage(message), base::Closure());
+ writer()->Write(SerializeAndFrameMessage(message), base::Closure());
}
void ClientControlDispatcher::NotifyClientResolution(
const ClientResolution& resolution) {
ControlMessage message;
message.mutable_client_resolution()->CopyFrom(resolution);
- writer_.Write(SerializeAndFrameMessage(message), base::Closure());
+ writer()->Write(SerializeAndFrameMessage(message), base::Closure());
}
void ClientControlDispatcher::ControlVideo(const VideoControl& video_control) {
ControlMessage message;
message.mutable_video_control()->CopyFrom(video_control);
- writer_.Write(SerializeAndFrameMessage(message), base::Closure());
+ writer()->Write(SerializeAndFrameMessage(message), base::Closure());
}
void ClientControlDispatcher::ControlAudio(const AudioControl& audio_control) {
ControlMessage message;
message.mutable_audio_control()->CopyFrom(audio_control);
- writer_.Write(SerializeAndFrameMessage(message), base::Closure());
+ writer()->Write(SerializeAndFrameMessage(message), base::Closure());
}
void ClientControlDispatcher::SetCapabilities(
const Capabilities& capabilities) {
ControlMessage message;
message.mutable_capabilities()->CopyFrom(capabilities);
- writer_.Write(SerializeAndFrameMessage(message), base::Closure());
+ writer()->Write(SerializeAndFrameMessage(message), base::Closure());
}
void ClientControlDispatcher::RequestPairing(
const PairingRequest& pairing_request) {
ControlMessage message;
message.mutable_pairing_request()->CopyFrom(pairing_request);
- writer_.Write(SerializeAndFrameMessage(message), base::Closure());
+ writer()->Write(SerializeAndFrameMessage(message), base::Closure());
}
void ClientControlDispatcher::DeliverClientMessage(
const ExtensionMessage& message) {
ControlMessage control_message;
control_message.mutable_extension_message()->CopyFrom(message);
- writer_.Write(SerializeAndFrameMessage(control_message), base::Closure());
+ writer()->Write(SerializeAndFrameMessage(control_message), base::Closure());
}
void ClientControlDispatcher::OnMessageReceived(
- scoped_ptr<ControlMessage> message, const base::Closure& done_task) {
+ scoped_ptr<ControlMessage> message,
+ const base::Closure& done_task) {
DCHECK(client_stub_);
DCHECK(clipboard_stub_);
base::ScopedClosureRunner done_runner(done_task);
« no previous file with comments | « remoting/protocol/client_control_dispatcher.h ('k') | remoting/protocol/client_event_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698