Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 841753003: IndexedDB: Revert change to enable reuse of leveldb manifest in IDB. (Closed)

Created:
5 years, 11 months ago by cmumford
Modified:
5 years, 11 months ago
Reviewers:
dgrogan, jsbell
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Revert change to enable reuse of leveldb manifest in IDB. The developer channel was showing spikes in %error when opening a leveldb. These spikes were between 0-10x the normal rates of errors. This change is a manual revert of #308493 (ddd0184). BUG=402980, 395799 Committed: https://crrev.com/ca6c87548326305bcced69aef5dd3fc41c0564ef Cr-Commit-Position: refs/heads/master@{#310338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/indexed_db/leveldb/leveldb_database.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
cmumford
Will take the first lgtm. Branch is in two days so reverting before then :-( ...
5 years, 11 months ago (2015-01-07 17:27:27 UTC) #2
jsbell
lgtm
5 years, 11 months ago (2015-01-07 17:28:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841753003/1
5 years, 11 months ago (2015-01-07 17:34:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 19:39:01 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 19:39:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca6c87548326305bcced69aef5dd3fc41c0564ef
Cr-Commit-Position: refs/heads/master@{#310338}

Powered by Google App Engine
This is Rietveld 408576698