Source/WebCore/rendering/RenderTable.cpp - Issue 8417039: Merge 98372 - Crash in WebCore::RenderTableSection::addChild due to assert failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/rendering/RenderTable.cpp

Issue 8417039: Merge 98372 - Crash in WebCore::RenderTableSection::addChild due to assert failure (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/912/

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/table/table-anonymous-section-bug-expected.txt ('k') | Source/WebCore/rendering/RenderTableRow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/rendering/RenderTable.cpp

===================================================================

--- Source/WebCore/rendering/RenderTable.cpp (revision 98739)

+++ Source/WebCore/rendering/RenderTable.cpp (working copy)

@@ -186,8 +186,7 @@

if (beforeChild && !beforeChild->isAnonymous() && beforeChild->parent() == this) {

RenderObject* section = beforeChild->previousSibling();

- if (section && section->isTableSection()) {

- ASSERT(section->isAnonymous());

+ if (section && section->isTableSection() && section->isAnonymous()) {

section->addChild(child);

return;

}

« no previous file with comments | « LayoutTests/fast/table/table-anonymous-section-bug-expected.txt ('k') | Source/WebCore/rendering/RenderTableRow.cpp » ('j') | no next file with comments »