Refactor loading out of ExtensionService.

chrome/browser/extensions/crx_installer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 #pragma once
 
 #include <string>
 
@@ skipping 30 matching lines @@
 // working with it, eg:
 //
 // scoped_refptr<CrxInstaller> installer(new CrxInstaller(...));
 // installer->set_foo();
 // installer->set_bar();
 // installer->InstallCrx(...);
 class CrxInstaller
     : public SandboxedExtensionUnpackerClient,
       public ExtensionInstallUI::Delegate {
  public:
+  // Extensions will be installed into frontend->install_directory(),
+  // then registered with |frontend|. Any install UI will be displayed
+  // using |client|. Pass NULL for |client| for silent install.
+  static scoped_refptr<CrxInstaller> Create(
+      ExtensionService* frontend,
+      ExtensionInstallUI* client);
+
   // This is pretty lame, but given the difficulty of connecting a particular
   // ExtensionFunction to a resulting download in the download manager, it's
   // currently necessary. This is the |id| of an extension to be installed
   // *by the web store only* which should not get the permissions install
   // prompt. This should only be called on the UI thread.
   // crbug.com/54916
   // TODO(asargent): This should be removed now that SetWhitelistEntry exists
   // http://crbug.com/100584
   static void SetWhitelistedInstallId(const std::string& id);
 
@@ skipping 24 matching lines @@
   // the return value and is responsible for deleting it.
   static WhitelistEntry* RemoveWhitelistEntry(const std::string& id);
 
   // Returns whether |id| is whitelisted - only call this on the UI thread.
   static bool IsIdWhitelisted(const std::string& id);
 
   // Returns whether |id| was found and removed (was whitelisted). This should
   // only be called on the UI thread.
   static bool ClearWhitelistedInstallId(const std::string& id);
 
-  // Constructor.  Extensions will be installed into
-  // frontend_weak->install_directory() then registered with
-  // |frontend_weak|. Any install UI will be displayed using
-  // |client|. Pass NULL for |client| for silent install.
-  CrxInstaller(base::WeakPtr<ExtensionService> frontend_weak,
-               ExtensionInstallUI* client);
-
   // Install the crx in |source_file|.
   void InstallCrx(const FilePath& source_file);
 
   // Convert the specified user script into an extension and install it.
   void InstallUserScript(const FilePath& source_file,
                          const GURL& download_url);
 
   // Convert the specified web app into an extension and install it.
   void InstallWebApp(const WebApplicationInfo& web_app);
 
@@ skipping 22 matching lines @@
   bool delete_source() const { return delete_source_; }
   void set_delete_source(bool val) { delete_source_ = val; }
 
   bool allow_silent_install() const { return allow_silent_install_; }
   void set_allow_silent_install(bool val) { allow_silent_install_ = val; }
 
   bool is_gallery_install() const {
     return (creation_flags_ & Extension::FROM_WEBSTORE) > 0;
   }
   void set_is_gallery_install(bool val) {
-    if (val) creation_flags_ |= Extension::FROM_WEBSTORE;
-    else creation_flags_ &= ~Extension::FROM_WEBSTORE;
+    if (val)
+      creation_flags_ |= Extension::FROM_WEBSTORE;
+    else
+      creation_flags_ &= ~Extension::FROM_WEBSTORE;
   }
 
   // The original download URL should be set when the WebstoreInstaller is
   // tracking the installation. The WebstoreInstaller uses this URL to match
   // failure notifications to the extension.
   const GURL& original_download_url() const { return original_download_url_; }
   void set_original_download_url(const GURL& url) {
     original_download_url_ = url;
   }
 
@@ skipping 18 matching lines @@
 
   void set_page_index(int page_index) {
     page_index_ = page_index;
   }
 
   Profile* profile() { return profile_; }
 
  private:
   friend class ExtensionUpdaterTest;
 
+  CrxInstaller(base::WeakPtr<ExtensionService> frontend_weak,
+               ExtensionInstallUI* client);
   virtual ~CrxInstaller();
 
   // Converts the source user script to an extension.
   void ConvertUserScriptOnFileThread();
 
   // Converts the source web app to an extension.
   void ConvertWebAppOnFileThread(const WebApplicationInfo& web_app);
 
   // Called after OnUnpackSuccess as a last check to see whether the install
   // should complete.
@@ skipping 124 matching lines @@
   extension_misc::CrxInstallCause install_cause_;
 
   // Creation flags to use for the extension.  These flags will be used
   // when calling Extenion::Create() by the crx installer.
   int creation_flags_;
 
   DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_