net/quic/quic_flags.cc - Issue 841603005: Change QUIC's RTO implementation. Protected by FLAGS_quic_use_new_rto.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/quic/quic_flags.cc

Issue 841603005: Change QUIC's RTO implementation. Protected by FLAGS_quic_use_new_rto. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Remove_transmission_stats_83598791

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/quic/quic_flags.h ('k') | net/quic/quic_sent_packet_manager.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/quic/quic_flags.h"	5 #include "net/quic/quic_flags.h"

6	6

7 bool FLAGS_quic_allow_oversized_packets_for_test = false;	7 bool FLAGS_quic_allow_oversized_packets_for_test = false;

8	8

9 // When true, the use time based loss detection instead of nack.	9 // When true, the use time based loss detection instead of nack.

10 bool FLAGS_quic_use_time_loss_detection = false;	10 bool FLAGS_quic_use_time_loss_detection = false;

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
69 // If true, uses the last sent packet for the RTO timer instead of the earliest.	69 // If true, uses the last sent packet for the RTO timer instead of the earliest.

70 bool FLAGS_quic_rto_uses_last_sent = true;	70 bool FLAGS_quic_rto_uses_last_sent = true;

71	71

72 // If true, attach QuicAckNotifiers to packets rather than individual stream	72 // If true, attach QuicAckNotifiers to packets rather than individual stream

73 // frames.	73 // frames.

74 bool FLAGS_quic_attach_ack_notifiers_to_packets = true;	74 bool FLAGS_quic_attach_ack_notifiers_to_packets = true;

75	75

76 // If true, the AckNotifierManager is informed about new packets as soon as they	76 // If true, the AckNotifierManager is informed about new packets as soon as they

77 // are serialized.	77 // are serialized.

78 bool FLAGS_quic_ack_notifier_informed_on_serialized = true;	78 bool FLAGS_quic_ack_notifier_informed_on_serialized = true;

	79

	80 // If true, QUIC will use the new RTO that waits until an ack arrives to adjust

	81 // the congestion window.

	82 bool FLAGS_quic_use_new_rto = false;
	Ian Swett 2015/01/14 15:39:04 I would suggest setting this to true. I would suggest setting this to true. ramant (doing other things) 2015/01/14 19:50:41 Hi Ian, Will enable this flag after we have made Show quoted text On 2015/01/14 15:39:04, Ian Swett wrote: > I would suggest setting this to true. Hi Ian, Will enable this flag after we have made sure all the tests with both FLAGS_quic_rto_uses_last_sent and FLAGS_quic_use_new_rto being true (based on the conersation we had over email). ramant (doing other things) 2015/01/14 21:28:31 Enabled the flag. Thanks Ian for the fix. Show quoted text On 2015/01/14 19:50:41, ramant wrote: > On 2015/01/14 15:39:04, Ian Swett wrote: > > I would suggest setting this to true. > > Hi Ian, > Will enable this flag after we have made sure all the tests with both > FLAGS_quic_rto_uses_last_sent and FLAGS_quic_use_new_rto being true (based on > the conersation we had over email). Enabled the flag. Thanks Ian for the fix.
OLD	NEW