Issue 841533004: Revert of Gracefully handle mismatched drag ended notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 841533004: Revert of Gracefully handle mismatched drag ended notifications. (Closed)

Created:
5 years, 11 months ago by sof

Modified:
5 years, 11 months ago

Reviewers:
jochen (gone - plz use gerrit), dcheng, Rick Byers

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Gracefully handle mismatched drag ended notifications. (patchset #3 id:40001 of https://codereview.chromium.org/839253002/) Reason for revert: Questions arose on the review after the CL entered CQ (and the author went to bed). Reverting until we're all aligned. Original issue's description: > Gracefully handle mismatched drag ended notifications. > > Should the embedder end up signalling the end of a drag operation > via EventHandler::dragSourceEndedAt(), but Blink has initiated > another drag operation, for whatever reason or source, then catch > this and gracefully bail. > > R=jochen,rbyers > BUG=445308 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188256 TBR=dcheng@chromium.org,jochen@chromium.org,rbyers@chromium.org NOTREECHECKS=true NOTRY=true BUG=445308 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188272

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -49 lines)			Patch
D	LayoutTests/fast/events/drag-extra-mouse-down-no-crash.html	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	LayoutTests/fast/events/drag-extra-mouse-down-no-crash-expected.txt	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/page/EventHandler.cpp	View	1 chunk	+1 line, -19 lines	0 comments	Download

Total messages: 3 (0 generated)

sof

Created Revert of Gracefully handle mismatched drag ended notifications.

5 years, 11 months ago (2015-01-13 06:22:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841533004/1

5 years, 11 months ago (2015-01-13 06:24:03 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-13 06:24:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188272