Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 841533002: Remove SkPDFDocument and SkPDFDevice from the public headers. (Closed)

Created:
5 years, 11 months ago by hal.canary
Modified:
5 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Another Patch Set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -512 lines) Patch
M gm/gmmain.cpp View 1 3 chunks +14 lines, -51 lines 0 comments Download
M gyp/pdf.gyp View 2 chunks +0 lines, -6 lines 0 comments Download
M gyp/pdf.gypi View 1 chunk +2 lines, -4 lines 0 comments Download
M gyp/tools.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
D include/pdf/SkPDFDevice.h View 1 chunk +0 lines, -339 lines 0 comments Download
D include/pdf/SkPDFDocument.h View 1 chunk +0 lines, -113 lines 0 comments Download
A + src/pdf/SkPDFDevice.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/pdf/SkPDFDocument.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
hal.canary
PTAL
5 years, 11 months ago (2015-01-06 16:08:58 UTC) #2
reed1
lgtm
5 years, 11 months ago (2015-01-06 16:10:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841533002/1
5 years, 11 months ago (2015-01-06 16:11:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/1442) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1417) Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot ...
5 years, 11 months ago (2015-01-06 16:13:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841533002/20001
5 years, 11 months ago (2015-01-06 16:19:46 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1419)
5 years, 11 months ago (2015-01-06 16:21:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841533002/40001
5 years, 11 months ago (2015-01-06 17:20:56 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://skia.googlesource.com/skia/+/8b1f761365df6652ea9304b6572d2dd91917b9aa
5 years, 11 months ago (2015-01-06 17:30:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841533002/40001
5 years, 11 months ago (2015-01-06 23:13:41 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 23:13:54 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/66b29a6ad5c92edeac855503db514319a113a9c0

Powered by Google App Engine
This is Rietveld 408576698