Removing HTTP Auth related command-line flags in favor of using prefs/policy

Removing HTTP Auth related command-line flags "--gssapi-library-name", "--enable-auth-negotiate-port", "--disable-auth-negotiate-cname-lookup" in favor of using prefs/policy

BUG=374951
Committed: https://crrev.com/b1e1098f50a33b54e55b1d3d5552959b02103083
Cr-Commit-Position: refs/heads/master@{#311030}

[anujsharma, 2015-01-06 09:34:24]

anujk.sharma@samsung.com changed reviewers:
+ thestig@chromium.org

[anujsharma, 2015-01-06 09:34:24]

PTAL

[Lei Zhang, 2015-01-06 20:21:42]

Deferring to cbentzel.

You may want to combine all the CLs for bug 374951 into a single CL. Otherwise,
they will all conflict with each other and you'll waste a lot of time resolving
conflicts.

[anujsharma, 2015-01-07 03:32:18]

On 2015/01/06 20:21:42, Lei Zhang wrote:
> Deferring to cbentzel.
> 
> You may want to combine all the CLs for bug 374951 into a single CL.
Otherwise,
> they will all conflict with each other and you'll waste a lot of time
resolving
> conflicts.

Thanks Lei Zhang for your review and your kind suggestion!!

I have merged all my three CL's to one for this bug.

@cbentzal-
Could you please take a look and gives a thumbs up.
Thanks!!

[anujsharma, 2015-01-07 03:34:39]

FYI,
Merged below CLs to one:
https://codereview.chromium.org/832423004/
https://codereview.chromium.org/818193005/
https://codereview.chromium.org/841493002/

[anujsharma, 2015-01-07 03:34:39]

FYI,
Merged below CLs to one:
https://codereview.chromium.org/832423004/
https://codereview.chromium.org/818193005/
https://codereview.chromium.org/841493002/

[anujsharma, 2015-01-07 16:47:34]

anujk.sharma@samsung.com changed reviewers:
+ mmenke@chromium.org

[anujsharma, 2015-01-07 16:50:31]

@mmenke
PTAL - io_thread changes

Thanks!!

[cbentzel, 2015-01-07 17:39:53]

On 2015/01/07 16:50:31, anujsharma wrote:
> @mmenke
> PTAL - io_thread changes
> 
> Thanks!!

This looks like it is removing the pref in addition to the command line flags,
unless I'm reading the CL wrong.

The bug is only to remove the command-line flags. I don't think we should remove
the prefs as there are policy configurations which feed into that.

[cbentzel, 2015-01-07 17:39:55]

On 2015/01/07 16:50:31, anujsharma wrote:
> @mmenke
> PTAL - io_thread changes
> 
> Thanks!!

This looks like it is removing the pref in addition to the command line flags,
unless I'm reading the CL wrong.

The bug is only to remove the command-line flags. I don't think we should remove
the prefs as there are policy configurations which feed into that.

[cbentzel, 2015-01-08 16:02:39]

cbentzel@chromium.org changed reviewers:
+ cbentzel@chromium.org

[anujsharma, 2015-01-09 07:34:40]

On 2015/01/07 17:39:55, cbentzel wrote:
> On 2015/01/07 16:50:31, anujsharma wrote:
> > @mmenke
> > PTAL - io_thread changes
> > 
> > Thanks!!
> 
> This looks like it is removing the pref in addition to the command line flags,
> unless I'm reading the CL wrong.
> 
> The bug is only to remove the command-line flags. I don't think we should
remove
> the prefs as there are policy configurations which feed into that.

Thanks cbentzel for yout time and comments.

I have modified the CL as per your comments.
PTAL

Thanks!!

[cbentzel, 2015-01-09 10:16:05]

LGTM

[anujsharma, 2015-01-09 10:28:22]

On 2015/01/09 10:16:05, cbentzel wrote:
> LGTM

Thanks cbentzel for lgtm.

[anujsharma, 2015-01-09 10:29:50]

@Lei Zhang,

Could you also give a thumbs for this CL. :)
Thanks!!

[mmenke, 2015-01-09 16:56:55]

Removing myself as a reviewer, as this no longer touches io_thread.

[mmenke, 2015-01-09 18:22:45]

mmenke@chromium.org changed reviewers:
- mmenke@chromium.org

[Lei Zhang, 2015-01-09 20:15:20]

Looks good, but you need to rebase. Patch set 3 no longer applies cleanly.

[anujsharma, 2015-01-10 10:10:36]

On 2015/01/09 20:15:20, Lei Zhang wrote:
> Looks good, but you need to rebase. Patch set 3 no longer applies cleanly.

@Lei Zhang
I have rebased the CL.
PTAL

Thank!!

[Lei Zhang, 2015-01-12 08:41:32]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-01-12 08:41:33]

lgtm

[commit-bot: I haz the power, 2015-01-12 08:41:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/841493002/60001

[anujsharma, 2015-01-12 08:48:09]

On 2015/01/12 08:41:33, Lei Zhang wrote:
> lgtm

Thanks Lei for lgtm.

[commit-bot: I haz the power, 2015-01-12 09:37:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-12 09:39:12]

Patchset 4 (id:??) landed as
https://crrev.com/b1e1098f50a33b54e55b1d3d5552959b02103083
Cr-Commit-Position: refs/heads/master@{#311030}