Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 841453005: Correctly resolve active descendant when describing change events. (Closed)

Created:
5 years, 11 months ago by David Tseng
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly resolve active descendant when describing change events. BUG= TEST=chromevox_tests (and manualy on Sheets format panel). Committed: https://crrev.com/7556b6b4ac505094335800f2f1bfea13d43e566d Cr-Commit-Position: refs/heads/master@{#311360}

Patch Set 1 #

Patch Set 2 : Rebase on master... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
David Tseng
5 years, 11 months ago (2015-01-13 21:37:35 UTC) #2
dmazzoni
lgtm
5 years, 11 months ago (2015-01-13 21:45:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841453005/1
5 years, 11 months ago (2015-01-13 21:46:23 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true in order for the CQ ...
5 years, 11 months ago (2015-01-13 21:46:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841453005/20001
5 years, 11 months ago (2015-01-13 22:37:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/48691)
5 years, 11 months ago (2015-01-13 23:05:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841453005/20001
5 years, 11 months ago (2015-01-13 23:14:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-13 23:32:08 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 23:33:22 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7556b6b4ac505094335800f2f1bfea13d43e566d
Cr-Commit-Position: refs/heads/master@{#311360}

Powered by Google App Engine
This is Rietveld 408576698