Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 841443004: [turbofan] Allow deoptimization for JSToNumber operator. (Closed)

Created:
5 years, 11 months ago by Jarin
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Allow deoptimization for JSToNumber operator. R=bmeurer@chromium.org Committed: https://crrev.com/ac04d777d6e3aba532d8172a73e8c94209e80cb3 Cr-Commit-Position: refs/heads/master@{#26053}

Patch Set 1 #

Patch Set 2 : More platforms #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -28 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ast.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/change-lowering.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/js-graph.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 5 chunks +42 lines, -15 lines 0 comments Download
M src/compiler/node-properties.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/node-properties-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +22 lines, -4 lines 0 comments Download
A + test/mjsunit/compiler/regress-445907.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
lgtm
5 years, 11 months ago (2015-01-14 12:43:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841443004/40001
5 years, 11 months ago (2015-01-14 12:43:51 UTC) #3
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-14 13:09:27 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 13:10:12 UTC) #5
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ac04d777d6e3aba532d8172a73e8c94209e80cb3
Cr-Commit-Position: refs/heads/master@{#26053}

Powered by Google App Engine
This is Rietveld 408576698