Issue 8414019: Removed normalization in AddFastProperty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8414019: Removed normalization in AddFastProperty (Closed)

Created:
9 years, 1 month ago by Sven Panne

Modified:
8 years, 8 months ago

Reviewers:
Lasse Reichstein, Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Removed normalization in AddFastProperty We don't have to go to slow mode when we add a property has name which is not an identifier, like e.g. '$*'.

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -30 lines)			Patch
	M	src/objects.cc	View		1 chunk	+0 lines, -30 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

9 years, 1 month ago (2011-10-28 08:25:33 UTC) #2

lgtm

I'm not sure why we originally did the normalization. Was it just a heuristic
(if you use non-identifiers, you're probably using the object as a dictionary)?

How does this affect benchmarks?

Expand Messages | Collapse Messages