Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: public/platform/WebPushClient.h

Issue 841333002: Push API: rename registration to subscription. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use https in the spec link. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/push_messaging/PushSubscriptionCallbacks.cpp ('k') | public/platform/WebPushProvider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebPushClient.h
diff --git a/public/platform/WebPushClient.h b/public/platform/WebPushClient.h
index f728bd7dc512637147d48f2a21b8206e92113f2e..1f9a6df598ea5dec58bc87f5b7425e290bc25ef9 100644
--- a/public/platform/WebPushClient.h
+++ b/public/platform/WebPushClient.h
@@ -11,9 +11,11 @@
namespace blink {
class WebServiceWorkerRegistration;
-struct WebPushRegistration;
+struct WebPushSubscription;
-typedef WebCallbacks<WebPushRegistration, WebPushError> WebPushRegistrationCallbacks;
+using WebPushSubscriptionCallbacks = WebCallbacks<WebPushSubscription, WebPushError>;
+// FIXME: Remove when no longer used by the embedder - https://crbug.com/446883.
+using WebPushRegistrationCallbacks = WebPushSubscriptionCallbacks;
class WebPushClient {
public:
@@ -21,7 +23,7 @@ public:
// Ownership of the WebServiceWorkerRegistration is not transferred.
// Ownership of the callbacks is transferred to the client.
- virtual void registerPushMessaging(WebServiceWorkerRegistration*, WebPushRegistrationCallbacks*) { }
+ virtual void registerPushMessaging(WebServiceWorkerRegistration*, WebPushRegistrationCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
};
} // namespace blink
« no previous file with comments | « Source/modules/push_messaging/PushSubscriptionCallbacks.cpp ('k') | public/platform/WebPushProvider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698