LayoutTests/http/tests/push_messaging/subscribe_success.html - Issue 841333002: Push API: rename registration to subscription.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/push_messaging/subscribe_success.html

Issue 841333002: Push API: rename registration to subscription. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Use https in the spec link. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/push_messaging/subscribe_permission_denied.html ('k') | LayoutTests/http/tests/push_messaging/subscribe_worker_not_activated.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/push_messaging/subscribe_success.html

diff --git a/LayoutTests/http/tests/push_messaging/register_success.html b/LayoutTests/http/tests/push_messaging/subscribe_success.html

similarity index 67%

rename from LayoutTests/http/tests/push_messaging/register_success.html

rename to LayoutTests/http/tests/push_messaging/subscribe_success.html

index 9520fb01cbe6a45fe026c678366950c8919d6d2c..196e6c4803369a3ba095fc47d46425643954b945 100644

--- a/LayoutTests/http/tests/push_messaging/register_success.html

+++ b/LayoutTests/http/tests/push_messaging/subscribe_success.html

@@ -1,7 +1,7 @@

<!DOCTYPE html>

<html>

<head>

-<title>register() succeeds when permission is granted and resolves with a valid registration</title>

+<title>subscribe() succeeds when permission is granted and resolves with a valid subscription</title>

@@ -22,16 +22,16 @@ async_test(function(test) {

// If running manually, grant permission when prompted.

if (self.testRunner)

testRunner.setPushMessagingPermission(location.origin, true);

- return swRegistration.pushManager.register();

+ return swRegistration.pushManager.subscribe();

})

- .then(function(pushRegistration) {

- assert_own_property(pushRegistration, 'registrationId');

- assert_equals(typeof pushRegistration.registrationId, 'string');

+ .then(function(pushSubscription) {

+ assert_own_property(pushSubscription, 'subscriptionId');

+ assert_equals(typeof pushSubscription.subscriptionId, 'string');

- assert_own_property(pushRegistration, 'endpoint');

- assert_equals(typeof pushRegistration.endpoint, 'string');

+ assert_own_property(pushSubscription, 'endpoint');

+ assert_equals(typeof pushSubscription.endpoint, 'string');

try {

- var endpointUrl = new URL(pushRegistration.endpoint);

+ var endpointUrl = new URL(pushSubscription.endpoint);

} catch(e) {

assert_unreached('Constructing a URL from the endpoint should not throw.');

}

@@ -39,7 +39,7 @@ async_test(function(test) {

return service_worker_unregister_and_done(test, workerScope);

})

.catch(unreached_rejection(test));

-}, 'register() succeeds when permission is granted and resolves with a valid registration');

+}, 'subscribe() succeeds when permission is granted and resolves with a valid subscription');

</script>

</body>

</html>