LayoutTests/http/tests/push_messaging/subscribe_permission_denied.html - Issue 841333002: Push API: rename registration to subscription.

Unified Diff: LayoutTests/http/tests/push_messaging/subscribe_permission_denied.html

Issue 841333002: Push API: rename registration to subscription. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/push_messaging/register_worker_not_activated.html ('k') | LayoutTests/http/tests/push_messaging/subscribe_success.html » ('j') | Source/modules/push_messaging/PushManager.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/push_messaging/subscribe_permission_denied.html

diff --git a/LayoutTests/http/tests/push_messaging/register_permission_denied.html b/LayoutTests/http/tests/push_messaging/subscribe_permission_denied.html

similarity index 76%

rename from LayoutTests/http/tests/push_messaging/register_permission_denied.html

rename to LayoutTests/http/tests/push_messaging/subscribe_permission_denied.html

index 179207aeb17f8c54fa1d7cf929a11b8088fbf0cc..1c550ac8d7f3aeca2b0c16392ff3eb23867e291c 100644

--- a/LayoutTests/http/tests/push_messaging/register_permission_denied.html

+++ b/LayoutTests/http/tests/push_messaging/subscribe_permission_denied.html

@@ -1,7 +1,7 @@

<!DOCTYPE html>

<html>

<head>

-<title>register() is rejected when permission has been denied</title>

+<title>subscribe() is rejected when permission has been denied</title>

@@ -22,17 +22,17 @@ async_test(function(test) {

// If running manually, deny permission when prompted.

if (self.testRunner)

testRunner.setPushMessagingPermission(location.origin, false);

- return swRegistration.pushManager.register();

+ return swRegistration.pushManager.subscribe();

})

- .then(function(pushRegistration) {

- assert_unreached('Registration must not succeed after permission is denied.');

+ .then(function(pushSubscription) {

+ assert_unreached('Subscription must not succeed after permission is denied.');

}, function(e) {

assert_equals(e.name, 'AbortError');

- assert_equals(e.message, 'Registration failed - permission denied');

+ assert_regexp_match(e.message, /permission denied/);

Peter Beverloo 2015/01/09 17:23:22 What's the benefit of doing this? Do you expect th

Michael van Ouwerkerk 2015/01/09 17:34:39 This error message comes from the embedder, we hav

return service_worker_unregister_and_done(test, workerScope);

})

.catch(unreached_rejection(test));

-}, 'register() is rejected when permission has been denied');

+}, 'subscribe() is rejected when permission has been denied');

</script>

</body>

</html>