Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Unified Diff: public/platform/WebPushProvider.h

Issue 841333002: Push API: rename registration to subscription. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: similarity=30 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebPushProvider.h
diff --git a/public/platform/WebPushProvider.h b/public/platform/WebPushProvider.h
index af5d353ca5dd451d46d832c0eb8b02074d23df42..5136b72cc666789ef94208b58629c8aab7084e24 100644
--- a/public/platform/WebPushProvider.h
+++ b/public/platform/WebPushProvider.h
@@ -13,11 +13,13 @@ namespace blink {
class WebServiceWorkerRegistration;
struct WebPushError;
-struct WebPushRegistration;
+struct WebPushSubscription;
-typedef WebCallbacks<WebPushRegistration, WebPushError> WebPushRegistrationCallbacks;
-typedef WebCallbacks<WebPushPermissionStatus, void> WebPushPermissionStatusCallbacks;
-typedef WebCallbacks<bool, WebPushError> WebPushUnregisterCallbacks;
+using WebPushSubscriptionCallbacks = WebCallbacks<WebPushSubscription, WebPushError>;
Peter Beverloo 2015/01/09 16:33:09 +FIXMEs
Michael van Ouwerkerk 2015/01/09 17:11:39 Done.
+using WebPushRegistrationCallbacks = WebPushSubscriptionCallbacks;
+using WebPushPermissionStatusCallbacks = WebCallbacks<WebPushPermissionStatus, void>;
+using WebPushUnsubscribeCallbacks = WebCallbacks<bool, WebPushError>;
+using WebPushUnregisterCallbacks = WebPushUnsubscribeCallbacks;
class WebPushProvider {
public:

Powered by Google App Engine
This is Rietveld 408576698