Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: public/platform/WebPushClient.h

Issue 841333002: Push API: rename registration to subscription. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: similarity=30 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebPushClient.h
diff --git a/public/platform/WebPushClient.h b/public/platform/WebPushClient.h
index f728bd7dc512637147d48f2a21b8206e92113f2e..97431c89aba730833c85c59df246523c34ff08ed 100644
--- a/public/platform/WebPushClient.h
+++ b/public/platform/WebPushClient.h
@@ -11,9 +11,10 @@
namespace blink {
class WebServiceWorkerRegistration;
-struct WebPushRegistration;
+struct WebPushSubscription;
-typedef WebCallbacks<WebPushRegistration, WebPushError> WebPushRegistrationCallbacks;
+using WebPushSubscriptionCallbacks = WebCallbacks<WebPushSubscription, WebPushError>;
Peter Beverloo 2015/01/09 16:33:09 +FIXME
Michael van Ouwerkerk 2015/01/09 17:11:39 Done.
+using WebPushRegistrationCallbacks = WebPushSubscriptionCallbacks;
class WebPushClient {
public:
@@ -21,7 +22,7 @@ public:
// Ownership of the WebServiceWorkerRegistration is not transferred.
// Ownership of the callbacks is transferred to the client.
- virtual void registerPushMessaging(WebServiceWorkerRegistration*, WebPushRegistrationCallbacks*) { }
+ virtual void registerPushMessaging(WebServiceWorkerRegistration*, WebPushRegistrationCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698