Chromium Code Reviews

Unified Diff: Source/modules/push_messaging/PushSubscription.h

Issue 841333002: Push API: rename registration to subscription. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: similarity=30 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: Source/modules/push_messaging/PushSubscription.h
diff --git a/Source/modules/push_messaging/PushRegistration.h b/Source/modules/push_messaging/PushSubscription.h
similarity index 46%
rename from Source/modules/push_messaging/PushRegistration.h
rename to Source/modules/push_messaging/PushSubscription.h
index 48551c188ac8ee2bfe181b15480e956dc444ea64..5bce2a75520329b021dbc36f6d04bb63dc07d9e7 100644
--- a/Source/modules/push_messaging/PushRegistration.h
+++ b/Source/modules/push_messaging/PushSubscription.h
@@ -1,9 +1,9 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors. All rights reserved.
Peter Beverloo 2015/01/09 16:33:09 nit: we usually don't change copyright years for p
Michael van Ouwerkerk 2015/01/09 17:11:39 Done.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef PushRegistration_h
-#define PushRegistration_h
+#ifndef PushSubscription_h
+#define PushSubscription_h
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptWrappable.h"
@@ -15,30 +15,30 @@ namespace blink {
class ServiceWorkerRegistration;
class ScriptPromiseResolver;
class ScriptState;
-struct WebPushRegistration;
+struct WebPushSubscription;
-class PushRegistration final : public GarbageCollectedFinalized<PushRegistration>, public ScriptWrappable {
+class PushSubscription final : public GarbageCollectedFinalized<PushSubscription>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
- static PushRegistration* take(ScriptPromiseResolver*, WebPushRegistration*, ServiceWorkerRegistration*);
- static void dispose(WebPushRegistration* registrationRaw);
+ static PushSubscription* take(ScriptPromiseResolver*, WebPushSubscription*, ServiceWorkerRegistration*);
+ static void dispose(WebPushSubscription* subscriptionRaw);
- virtual ~PushRegistration();
+ virtual ~PushSubscription();
const String& endpoint() const { return m_endpoint; }
- const String& registrationId() const { return m_registrationId; }
- ScriptPromise unregister(ScriptState*);
+ const String& subscriptionId() const { return m_subscriptionId; }
+ ScriptPromise unsubscribe(ScriptState*);
void trace(Visitor*);
private:
- PushRegistration(const String& endpoint, const String& registrationId, ServiceWorkerRegistration*);
+ PushSubscription(const String& endpoint, const String& subscriptionId, ServiceWorkerRegistration*);
String m_endpoint;
- String m_registrationId;
+ String m_subscriptionId;
Member<ServiceWorkerRegistration> m_serviceWorkerRegistration;
};
} // namespace blink
-#endif // PushRegistration_h
+#endif // PushSubscription_h

Powered by Google App Engine