Source/modules/push_messaging/PushManager.idl - Issue 841333002: Push API: rename registration to subscription.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/push_messaging/PushManager.idl

Issue 841333002: Push API: rename registration to subscription. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // http://w3c.github.io/push-api/#pushregistrationmanager-interface	5 // http://w3c.github.io/push-api/#pushmanager-interface
	Peter Beverloo 2015/01/09 17:23:22 micro nit: https:// micro nit: https:// Michael van Ouwerkerk 2015/01/09 17:34:39 Done. Show quoted text On 2015/01/09 17:23:22, Peter Beverloo wrote: > micro nit: https:// Done.
6	6

7 [	7 [

8 GarbageCollected,	8 GarbageCollected,

9 RuntimeEnabled=PushMessaging,	9 RuntimeEnabled=PushMessaging,

10 ] interface PushManager {	10 ] interface PushManager {

11 [CallWith=ScriptState, ImplementedAs=registerPushMessaging] Promise register ();	11 [CallWith=ScriptState] Promise<PushSubscription> subscribe();

12 [CallWith=ScriptState] Promise<PushRegistration?> getRegistration();	12 [CallWith=ScriptState] Promise<PushSubscription?> getSubscription();

13 [CallWith=ScriptState] Promise hasPermission();	13 [CallWith=ScriptState] Promise hasPermission();

14 };	14 };

OLD	NEW