Changes to upload tracked_objects data from all renderer

chrome/renderer/renderer_tracking.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/renderer/renderer_tracking.h"
+
+#include <ctype.h>
+
+#include "base/json/json_writer.h"
+#include "base/logging.h"
+#include "base/message_loop.h"
+#include "base/tracked_objects.h"
+#include "chrome/common/render_messages.h"
+#include "content/public/renderer/render_thread.h"
+
+using content::RenderThread;
+
+RendererTracking::RendererTracking()
+    : ALLOW_THIS_IN_INITIALIZER_LIST(renderer_tracking_factory_(this)) {
+}
+
+RendererTracking::~RendererTracking() {
+}
+
+bool RendererTracking::OnControlMessageReceived(const IPC::Message& message) {
+  bool handled = true;
+  IPC_BEGIN_MESSAGE_MAP(RendererTracking, message)
+    IPC_MESSAGE_HANDLER(ChromeViewMsg_GetRendererTrackedData,
+                        OnGetRendererTrackingData)
+    IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_END_MESSAGE_MAP()
+  return handled;
+}
+
+void RendererTracking::OnGetRendererTrackingData(int sequence_number) {
+  RenderThread::Get()->GetMessageLoop()->PostTask(FROM_HERE,
+      renderer_tracking_factory_.NewRunnableMethod(
+          &RendererTracking::UploadAllTrackingData, sequence_number));
+}
+
+void RendererTracking::UploadAllTrackingData(int sequence_number) {
+  // TODO(rtenneti): figure out process type. (pass the process type as
+  // argument). Get the process id of the current process.

[jar (doing other things), 2011/10/30 08:04:19]

I think it might be easier to establish process type back in the browser, when
you were itterating over lists. For example, although there is a render process
list, there might be a few items that are not part of a list, or you might have
to itterate on more than one list... and that list would indicate the type of
process.  Assuming this was determined browser side, you could then IPC pass in
the process type (in addition to the sequence number), and then just pop it into
place here (in the Value).

[ramant (doing other things), 2011/11/01 00:52:15]

Done.

+  scoped_ptr<base::Value> value(
+      tracked_objects::ThreadData::ToValue(0));
+  // value->SetInteger("process", process_type);
+  // value->SetInteger("process_id", process_id);
+
+  base::JSONWriter::Write(value.get(), false, &pickled_tracking_data_);
+
+  // Send the sequence number and list of pickled tracking data over synchronous

[jar (doing other things), 2011/10/30 08:04:19]

I think you're on the main renderer thread.  I don't think you nede to do
anything synchronously... but you do possibly have to Post back over to the IO
thread.

[ramant (doing other things), 2011/11/01 00:52:15]

Used logic similar to "renderer histograms". 

+  // IPC, so we can clear pickled_tracking_data_ afterwards.
+  RenderThread::Get()->Send(new ChromeViewHostMsg_RendererTrackedData(
+      sequence_number, pickled_tracking_data_));
+}