Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 841173003: analysis_canvas_unittest: tilegrid -> rtree (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

analysis_canvas_unittest: tilegrid -> rtree This updates analysis_canvas_unittest.cc to match the rest of Chromium, using an SkRTree instead of an SkTileGrid. This helps us delete SkTileGrid. The remaining references to SkTileGridFactory are all just to SkTileGridFactory::TileGridInfo, which I'll clean up in another pass. BUG=skia:3085 Committed: https://crrev.com/654791af847d3d323dc898db3d6bdeb0834fb512 Cr-Commit-Position: refs/heads/master@{#310768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M skia/ext/analysis_canvas_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mtklein
5 years, 11 months ago (2015-01-08 21:15:41 UTC) #2
robertphillips
lgtm
5 years, 11 months ago (2015-01-09 13:24:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841173003/1
5 years, 11 months ago (2015-01-09 13:31:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 14:12:39 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 14:13:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/654791af847d3d323dc898db3d6bdeb0834fb512
Cr-Commit-Position: refs/heads/master@{#310768}

Powered by Google App Engine
This is Rietveld 408576698