MacViews: Fix duplicate ShowSessionCrashBubble and ShowProfileResetBubble

MacViews: Fix duplicate ShowSessionCrashBubble and ShowProfileResetBubble

ShowSessionCrashBubble and ShowProfileResetBubble are global functions with
2 definitions (Cocoa and Views).
Refactor them into virtual methods in BrowserWindow to avoid duplicate
definitions and to ensure that the right bubbles are invoked for the browser
window.

BUG=425229
Committed: https://crrev.com/4b96a1f8944ee15e50a7a8bd752cf2169afc9741
Cr-Commit-Position: refs/heads/master@{#310783}

[Andre, 2015-01-08 22:12:05]

andresantoso@chromium.org changed reviewers:
+ sky@chromium.org

[Andre, 2015-01-08 22:12:05]

sky@ please review.

[sky, 2015-01-09 00:48:56]

Long term we don't want these functions on BrowserWindow. Is there a better way
to structure the code so we don't end up with code we don't want in the long
term?

[Andre, 2015-01-09 01:31:37]

On 2015/01/09 00:48:56, sky wrote:
> Long term we don't want these functions on BrowserWindow. Is there a better
way
> to structure the code so we don't end up with code we don't want in the long
> term?

BrowserWindow seems to be where many of these window modal dialog invoking
methods
and bubbles live (ShowUpdateChromeDialog, ShowBookmarkBubble,
ShowBookmarkAppBubble,
ShowTranslateBubble).
Do you have something in mind where they should be long term?

[sky, 2015-01-09 16:41:21]

The reason some of these functions are on BrowserWindow is they need state from
the window/browser. The session bubbles didn't, so it didn't make sense to have
them on BrowserWindow and is why I was hoping to keep them off BrowserWindow.

But, you need the context of BrowserWindow, so it makes sense to move the
functions to BrowserWindow.

LGTM

[Andre, 2015-01-09 16:45:17]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2015-01-09 16:45:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/841163002/1

[commit-bot: I haz the power, 2015-01-09 16:59:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-09 17:00:11]

Patchset 1 (id:??) landed as
https://crrev.com/4b96a1f8944ee15e50a7a8bd752cf2169afc9741
Cr-Commit-Position: refs/heads/master@{#310783}