Reverse the change in crrev.com/222879

Reverse the change in crrev.com/222879

Allow toplevel widgets to be created for combobox menus.

BUG=288988
R=erg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236968

[sadrul, 2013-11-22 21:46:45]

I am not sure what was broken that required the change, but reverting it doesn't
seem to break anything? Perhaps the issue went away with some of the activation
related changes?

[Elliot Glaysher, 2013-11-22 23:06:09]

lgtm.

I also vaguely remember there being a widget unittest (interactive ui tests?)
that was disabled along with this. (Looked it up:
WidgetTest.DesktopAuraTopLevelOwnedPopupTest. Also passes locally with your
change.)

(This case used to be very, very broken. Without the above hack, combobox
dropdowns would flash in, and then would immediately disappear. Probably
activation related.)

[sadrul, 2013-11-22 23:16:58]

On 2013/11/22 23:06:09, Elliot Glaysher wrote:
> lgtm.
> 
> I also vaguely remember there being a widget unittest (interactive ui tests?)
> that was disabled along with this. (Looked it up:
> WidgetTest.DesktopAuraTopLevelOwnedPopupTest. Also passes locally with your
> change.)

Re-enabled the test and sent to trybots. Let's see how things go.
(interactive_ui_tests pass locally with this change)

> 
> (This case used to be very, very broken. Without the above hack, combobox
> dropdowns would flash in, and then would immediately disappear. Probably
> activation related.)

[sadrul, 2013-11-23 20:49:43]

Committed patchset #2 manually as r236968 (presubmit successful).