Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 841113003: Rewrite how skydb starts prompt.cc (Closed)

Created:
5 years, 11 months ago by eseidel
Modified:
5 years, 11 months ago
Reviewers:
jamesr, abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rewrite how skydb starts prompt.cc This makes skydb pass a command_port to prompt.cc as a commandline argument. I removed passing of the url and instead pass the url via a separate /load command. This has the nice side effect of guarenteeing that the sky instance is up and ready to respond to commands when skydb exits. It also prepares us for running more than one copy of prompt.cc as jamesr requested for both Release and Debug or for on both your android device as well as your local machine. R=abarth@chromium.org, jamesr@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/9958496d43ac5d002dabfb453a0e19bc540b624d

Patch Set 1 #

Patch Set 2 : updated #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -47 lines) Patch
M sky/tools/debugger/prompt/prompt.cc View 6 chunks +17 lines, -14 lines 1 comment Download
M sky/tools/skydb View 7 chunks +56 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eseidel
5 years, 11 months ago (2015-01-08 23:48:26 UTC) #1
abarth-chromium
LGTM
5 years, 11 months ago (2015-01-08 23:49:36 UTC) #2
eseidel
Committed patchset #2 (id:20001) manually as 9958496d43ac5d002dabfb453a0e19bc540b624d (presubmit successful).
5 years, 11 months ago (2015-01-08 23:50:14 UTC) #3
jamesr
5 years, 11 months ago (2015-01-08 23:50:38 UTC) #4
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/841113003/diff/20001/sky/tools/debugger/promp...
File sky/tools/debugger/prompt/prompt.cc (right):

https://codereview.chromium.org/841113003/diff/20001/sky/tools/debugger/promp...
sky/tools/debugger/prompt/prompt.cc:159: unsigned command_port_;
please use uint32_t.  unsigned is longer to type and ambiguous about how many
bits it holds

Powered by Google App Engine
This is Rietveld 408576698