Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 841103003: Fix WeakPtrFactory member in LoginDisplayHostImpl (Closed)

Created:
5 years, 11 months ago by dmichael (off chromium)
Modified:
5 years, 11 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member in LoginDisplayHostImpl This forces WeakPtrs to be invalidated before other members' destructors run. See the bug or the documentation of WeakPtrFactory for more information. I'm in the process of trying to turn on a clang check for this (see the bug). BUG=303818 R=stevenjb@chromium.org Committed: https://crrev.com/51b7efebea361ee9a0bcff532470ffe61335ea2d Cr-Commit-Position: refs/heads/master@{#311373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/chromeos/login/ui/login_display_host_impl.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
dmichael (off chromium)
5 years, 11 months ago (2015-01-13 23:37:20 UTC) #1
stevenjb
lgtm
5 years, 11 months ago (2015-01-14 00:25:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841103003/1
5 years, 11 months ago (2015-01-14 00:35:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 00:42:59 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 00:44:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51b7efebea361ee9a0bcff532470ffe61335ea2d
Cr-Commit-Position: refs/heads/master@{#311373}

Powered by Google App Engine
This is Rietveld 408576698