Issue 841083002: Remove "extra checks"

Issue 841083002: Remove "extra checks" (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 11 months ago

Reviewers:
dcarney, Michael Achenbach

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Remove "extra checks" Instead, just use DCHECKs. The builders that want them in release mode should already be useding dcheck_always_on anyways BUG=none R=machenbach@chromium.org LOG=y Committed: https://crrev.com/0959123e570ba339045db35dda0d6af5cf016669 Cr-Commit-Position: refs/heads/master@{#26001}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -43 lines)			Patch
M	BUILD.gn	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Makefile	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/features.gypi	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	src/api.h	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/base/logging.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	2 chunks	+4 lines, -8 lines	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x87/macro-assembler-x87.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841083002/1

5 years, 11 months ago (2015-01-08 16:02:20 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-08 16:29:50 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0959123e570ba339045db35dda0d6af5cf016669
Cr-Commit-Position: refs/heads/master@{#26001}