Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 841013003: Add util script for killing chrome shell. (Closed)

Created:
5 years, 11 months ago by william.xie1
Modified:
5 years, 11 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add util scripts for killing chrome shell. BUG=None TEST= Committed: https://crrev.com/0a70b9f2f5fad8b3176eeb10663d96e8f57f6b89 Cr-Commit-Position: refs/heads/master@{#310652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
A + build/android/adb_kill_chrome_shell View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
william.xie1
Hi John Would you please kindly review the patch? Thanks William
5 years, 11 months ago (2015-01-08 05:57:59 UTC) #2
jbudorick
lgtm
5 years, 11 months ago (2015-01-08 14:19:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/841013003/1
5 years, 11 months ago (2015-01-08 23:41:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 01:27:58 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 01:29:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a70b9f2f5fad8b3176eeb10663d96e8f57f6b89
Cr-Commit-Position: refs/heads/master@{#310652}

Powered by Google App Engine
This is Rietveld 408576698