Alternate status page

pkg/analysis_server/tool/spec/codegen_dart_protocol.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library codegen.protocol;
 
 import 'dart:convert';
 
 import 'package:html5lib/dom.dart' as dom;
 
@@ skipping 236 matching lines @@
       }
       for (TypeEnumValue value in type.values) {
         docComment(toHtmlVisitor.collectHtml(() {
           toHtmlVisitor.translateHtml(value.html);
         }));
         String valueString = literalString(value.value);
         writeln(
             'static const ${value.value} = const $className._($valueString);');
         writeln();
       }
+
+      writeln('/**');
+      writeln(' * A list containing all of the services that are defined.');

[Paul Berry, 2015/01/20 17:28:11]

This looks like it will run on all enums, not just enums describing services, so
the comment should say something like "A list containing all of the enum values
that are defined."

Also, was this part of an incomplete thought?  It doesn't look like you ran the
code generator, and I didn't notice you depending on the new constant anywhere.

[Brian Wilkerson, 2015/01/20 17:46:35]

Done.
Yes, I ran the generator, and yes, I'm using it.

+      writeln(' */');
+      write('static const List<');
+      write(className);
+      write('> VALUES = const <');
+      write(className);
+      write('>[');
+      bool first = true;
+      for (TypeEnumValue value in type.values) {
+        if (first) {
+          first = false;
+        } else {
+          write(', ');
+        }
+        write(value.value);
+      }
+      writeln('];');
+      writeln();
+
       writeln('final String name;');
       writeln();
       writeln('const $className._(this.name);');
       writeln();
       emitEnumClassConstructor(className, type);
       writeln();
       emitEnumFromJsonConstructor(className, type, impliedType);
       writeln();
       if (emitSpecialConstructors(className)) {
         writeln();
@@ skipping 906 matching lines @@
 
   @override
   String get asClosure => '($type value) => ${callback('value')}';
 
   @override
   bool get isIdentity => false;
 
   @override
   String asSnippet(String value) => callback(value);
 }