Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 840933003: Async DNS: Remove toggle from about:flags (Closed)

Created:
5 years, 11 months ago by Deprecated (see juliatuttle)
Modified:
5 years, 11 months ago
Reviewers:
Bence, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Async DNS: Remove toggle from about:flags Async DNS is fairly stable at the moment, so we don't really need the toggle in about:flags anymore. (Note that the --enable-async-dns and --disable-async-dns command-line flags will still work for now.) BUG=432236 Committed: https://crrev.com/eabf1f5baba38d46921acd6edda594f942f7d6a1 Cr-Commit-Position: refs/heads/master@{#310552}

Patch Set 1 #

Patch Set 2 : Remove strings from build/ios/grit_whitelist.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M build/ios/grit_whitelist.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Bence
Don't you need to remove DS_FLAGS_ENABLE_ASYNC_DNS_* from build/ios/grit_whitelist.txt as well?
5 years, 11 months ago (2015-01-08 14:26:21 UTC) #2
Deprecated (see juliatuttle)
On 2015/01/08 14:26:21, Bence wrote: > Don't you need to remove DS_FLAGS_ENABLE_ASYNC_DNS_* from > build/ios/grit_whitelist.txt ...
5 years, 11 months ago (2015-01-08 16:53:53 UTC) #3
Bence
LGTM.
5 years, 11 months ago (2015-01-08 16:55:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840933003/20001
5 years, 11 months ago (2015-01-08 16:57:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/34066)
5 years, 11 months ago (2015-01-08 17:05:30 UTC) #8
Deprecated (see juliatuttle)
thakis, PTAL at build/ios/grit_whitelist.txt.
5 years, 11 months ago (2015-01-08 17:30:30 UTC) #10
Nico
lgtm
5 years, 11 months ago (2015-01-08 18:59:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840933003/20001
5 years, 11 months ago (2015-01-08 19:00:08 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-08 19:05:38 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 19:07:12 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eabf1f5baba38d46921acd6edda594f942f7d6a1
Cr-Commit-Position: refs/heads/master@{#310552}

Powered by Google App Engine
This is Rietveld 408576698