Issue 840923002: Remove the keyboard from the browser demo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 840923002: Remove the keyboard from the browser demo. (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher

Modified:
5 years, 11 months ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove the keyboard from the browser demo. It isn't being used and is the most complicated use of views in the mojo tree. BUG=443439 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/232a18df6c79c1f7b7695f5a8db3c15965045bd9

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -1074 lines)			Patch
M	examples/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	examples/browser/browser.cc	View	2 chunks	+0 lines, -91 lines	0 comments	Download
D	examples/keyboard/BUILD.gn	View	1 chunk	+0 lines, -52 lines	0 comments	Download
D	examples/keyboard/keyboard.cc	View	1 chunk	+0 lines, -150 lines	0 comments	Download
D	examples/keyboard/keyboard.mojom	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	examples/keyboard/keyboard_delegate.h	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	examples/keyboard/keyboard_view.h	View	1 chunk	+0 lines, -104 lines	0 comments	Download
D	examples/keyboard/keyboard_view.cc	View	1 chunk	+0 lines, -256 lines	0 comments	Download
D	examples/keyboard/keys.h	View	1 chunk	+0 lines, -62 lines	0 comments	Download
D	examples/keyboard/keys.cc	View	1 chunk	+0 lines, -186 lines	0 comments	Download
M	examples/window_manager/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	examples/window_manager/window_manager.cc	View	9 chunks	+2 lines, -119 lines	0 comments	Download
M	examples/window_manager/window_manager.mojom	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Elliot Glaysher

5 years, 11 months ago (2015-01-07 22:44:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
232a18df6c79c1f7b7695f5a8db3c15965045bd9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages