Unit test for 417HighLevelEncoder

Unit test for 417HighLevelEncoder

R=bo_xu@foxitsoftware.com

Committed: https://pdfium.googlesource.com/pdfium/+/5f21e9ddd181fc344f8d6070351858f98a25547e

[Tom Sepez, 2015-01-07 21:58:31]

tsepez@chromium.org changed reviewers:
+ bo_xu@foxitsoftware.com

[Tom Sepez, 2015-01-07 21:58:31]

Bo, now that we have a unit test infrastructure, we can try to back-fill the
unit test for the PDF417 patch you landed last week.

[Bo Xu, 2015-01-07 23:11:17]

https://codereview.chromium.org/840903002/diff/1/xfa/src/fxbarcode/src/BC_PDF...
File xfa/src/fxbarcode/src/BC_PDF417HighLevelEncoder_unittest.cpp (right):

https://codereview.chromium.org/840903002/diff/1/xfa/src/fxbarcode/src/BC_PDF...
xfa/src/fxbarcode/src/BC_PDF417HighLevelEncoder_unittest.cpp:33: };
How are the expected wchar_t* obtained? Can we have a comment here so more cases
could be added later on?

[Tom Sepez, 2015-01-09 23:31:00]

>
https://codereview.chromium.org/840903002/diff/1/xfa/src/fxbarcode/src/BC_PDF...
> xfa/src/fxbarcode/src/BC_PDF417HighLevelEncoder_unittest.cpp:33: };
> How are the expected wchar_t* obtained? Can we have a comment here so more
cases
> could be added later on?
Like anything else, they're derived by hand based upon the expected behaviour of
the code.

I'll add some comments about why these cases were chosen.

[Tom Sepez, 2015-01-10 00:09:04]

On 2015/01/09 23:31:00, Tom Sepez wrote:
> >
>
https://codereview.chromium.org/840903002/diff/1/xfa/src/fxbarcode/src/BC_PDF...
> > xfa/src/fxbarcode/src/BC_PDF417HighLevelEncoder_unittest.cpp:33: };
> > How are the expected wchar_t* obtained? Can we have a comment here so more
> cases
> > could be added later on?
> Like anything else, they're derived by hand based upon the expected behaviour
of
> the code.
> 
> I'll add some comments about why these cases were chosen.
Done.

[Bo Xu, 2015-01-10 00:22:58]

On 2015/01/10 00:09:04, Tom Sepez wrote:
> On 2015/01/09 23:31:00, Tom Sepez wrote:
> > >
> >
>
https://codereview.chromium.org/840903002/diff/1/xfa/src/fxbarcode/src/BC_PDF...
> > > xfa/src/fxbarcode/src/BC_PDF417HighLevelEncoder_unittest.cpp:33: };
> > > How are the expected wchar_t* obtained? Can we have a comment here so more
> > cases
> > > could be added later on?
> > Like anything else, they're derived by hand based upon the expected
behaviour
> of
> > the code.
> > 
> > I'll add some comments about why these cases were chosen.
> Done.

LGTM, thanks!

[Tom Sepez, 2015-01-10 00:25:11]

Committed patchset #3 (id:40001) manually as
5f21e9ddd181fc344f8d6070351858f98a25547e (presubmit successful).