Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 840893002: Upstream the sign out and add an account dialogs. (Closed)

Created:
5 years, 11 months ago by aruslan
Modified:
5 years, 11 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream the sign out and add an account dialogs. BUG=428880 Committed: https://crrev.com/0a7cd36ab4c3d2c7d9fe9a56056f075d388facb9 Cr-Commit-Position: refs/heads/master@{#310401}

Patch Set 1 #

Patch Set 2 : Year #

Total comments: 10

Patch Set 3 : Descriptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -0 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/signin/AddGoogleAccountDialogFragment.java View 1 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/signin/SignOutDialogFragment.java View 1 chunk +75 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
aruslan
Please take a look, thanks!
5 years, 11 months ago (2015-01-07 21:54:30 UTC) #2
newt (away)
Could you update a few string descriptions? Then lgtm. Thanks! https://codereview.chromium.org/840893002/diff/20001/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/840893002/diff/20001/chrome/android/java/strings/android_chrome_strings.grd#newcode336 ...
5 years, 11 months ago (2015-01-07 22:01:00 UTC) #3
aruslan
Thanks, PTAL. https://codereview.chromium.org/840893002/diff/20001/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/840893002/diff/20001/chrome/android/java/strings/android_chrome_strings.grd#newcode336 chrome/android/java/strings/android_chrome_strings.grd:336: <message name="IDS_ADD_ACCOUNT_TITLE" desc="Add account message for add ...
5 years, 11 months ago (2015-01-07 22:11:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840893002/40001
5 years, 11 months ago (2015-01-07 22:15:37 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-07 23:01:39 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 23:04:15 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0a7cd36ab4c3d2c7d9fe9a56056f075d388facb9
Cr-Commit-Position: refs/heads/master@{#310401}

Powered by Google App Engine
This is Rietveld 408576698