Files.app: Add a new column in table view to reflect cloud import status.

Files.app: Add a new column in table view to reflect cloud import status.

- Add a new column to the file table to show icons representing cloud import status.
- Add new styles for media that's been locally copied and added to Drive.
- Add code to manage status updates.

BUG=420680
Committed: https://crrev.com/175d4c6874d1c7a20ca7b5a8011052fc86847aac
Cr-Commit-Position: refs/heads/master@{#311704}

[Ben Kwa, 2015-01-13 23:28:02]

kenobi@chromium.org changed reviewers:
+ mtomasz@chromium.org, smckay@chromium.org

[mtomasz, 2015-01-14 00:34:35]

lgtm with nits

https://codereview.chromium.org/840863004/diff/1/chrome/app/chromeos_strings....
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/840863004/diff/1/chrome/app/chromeos_strings....
chrome/app/chromeos_strings.grdp:181: <message
name="IDS_FILE_BROWSER_STATUS_COLUMN_LABEL" desc="Status column label.">
nit: This may not be clear enough for translators. Can we add example statuses
to the description?

https://codereview.chromium.org/840863004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/css/file_status.css (right):

https://codereview.chromium.org/840863004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/css/file_status.css:1: /* Copyright (c)
2012 The Chromium Authors. All rights reserved.
(c) 2012 -> 2015

https://codereview.chromium.org/840863004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right):

https://codereview.chromium.org/840863004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/ui/file_table.js:723: } else if (type
=== 'import-history') {
Is it method ever called with this type?

[Ben Kwa, 2015-01-14 16:19:34]

Thanks!

https://codereview.chromium.org/840863004/diff/1/chrome/app/chromeos_strings....
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/840863004/diff/1/chrome/app/chromeos_strings....
chrome/app/chromeos_strings.grdp:181: <message
name="IDS_FILE_BROWSER_STATUS_COLUMN_LABEL" desc="Status column label.">
On 2015/01/14 00:34:34, mtomasz wrote:
> nit: This may not be clear enough for translators. Can we add example statuses
> to the description?

Done.

https://codereview.chromium.org/840863004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/css/file_status.css (right):

https://codereview.chromium.org/840863004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/css/file_status.css:1: /* Copyright (c)
2012 The Chromium Authors. All rights reserved.
On 2015/01/14 00:34:34, mtomasz wrote:
> (c) 2012 -> 2015

Done.

https://codereview.chromium.org/840863004/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right):

https://codereview.chromium.org/840863004/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/ui/file_table.js:723: } else if (type
=== 'import-history') {
On 2015/01/14 00:34:34, mtomasz wrote:
> Is it method ever called with this type?

Yes, code was added to the FileManager to call this method with this new type of
update, when an import history change is detected.

[Steve McKay, 2015-01-14 20:30:16]

https://codereview.chromium.org/840863004/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/840863004/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:807: // TODO(smckay):
Update listview when that view is visible.
Nuke the todo. Also, do we need to avoid updating one or the other?

https://codereview.chromium.org/840863004/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right):

https://codereview.chromium.org/840863004/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/file_table.js:261: new
cr.ui.table.TableColumn('status', str('STATUS_COLUMN_LABEL'),
Will this be visible to everyone in all contexts? SHould it not be constrained
to just eligible media mounts and only when the feature is enabled?

[Ben Kwa, 2015-01-15 16:36:56]

https://codereview.chromium.org/840863004/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/840863004/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:807: // TODO(smckay):
Update listview when that view is visible.
On 2015/01/14 20:30:16, Steve McKay wrote:
> Nuke the todo. Also, do we need to avoid updating one or the other?

Done.
Re updating one or the other - the code in ListContainer looks like the table
and grid are meant to be updated in sync.  I think this makes sense since it
reduces complexity when switching between views.

https://codereview.chromium.org/840863004/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right):

https://codereview.chromium.org/840863004/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/file_table.js:261: new
cr.ui.table.TableColumn('status', str('STATUS_COLUMN_LABEL'),
On 2015/01/14 20:30:16, Steve McKay wrote:
> Will this be visible to everyone in all contexts? SHould it not be constrained
> to just eligible media mounts and only when the feature is enabled?

Partially done - fixed to only show this column when the cloud import feature is
enabled.  For showing/hiding the column only for eligible media mounts, that's
considerably more complex, so if that's okay I'd like to handle it as a
follow-on CL.

[Steve McKay, 2015-01-15 17:37:27]

LGTM

[Steve McKay, 2015-01-15 17:37:35]

The CQ bit was checked by smckay@chromium.org

[commit-bot: I haz the power, 2015-01-15 17:38:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/840863004/60001

[commit-bot: I haz the power, 2015-01-15 17:42:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 17:42:32]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/11...)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ben Kwa, 2015-01-15 17:49:56]

The CQ bit was checked by kenobi@chromium.org

[commit-bot: I haz the power, 2015-01-15 17:50:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/840863004/80001

[commit-bot: I haz the power, 2015-01-15 18:46:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-15 18:47:48]

Patchset 5 (id:??) landed as
https://crrev.com/175d4c6874d1c7a20ca7b5a8011052fc86847aac
Cr-Commit-Position: refs/heads/master@{#311704}