Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 840863003: gn: declare is_desktop_linux as a build argument (Closed)

Created:
5 years, 11 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: declare is_desktop_linux as a build argument BUG=448159 Committed: https://crrev.com/e925a3b964d080423a2aef982c193139c4c4cca3 Cr-Commit-Position: refs/heads/master@{#311236}

Patch Set 1 #

Patch Set 2 : fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/config/BUILDCONFIG.gn View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Mostyn Bramley-Moore
@brettw: PTAL
5 years, 11 months ago (2015-01-12 22:44:28 UTC) #2
brettw
Can you help me understand why you need to set this? Do you override this ...
5 years, 11 months ago (2015-01-13 02:26:39 UTC) #3
Mostyn Bramley-Moore
On 2015/01/13 02:26:39, brettw wrote: > Can you help me understand why you need to ...
5 years, 11 months ago (2015-01-13 06:54:23 UTC) #4
brettw
lgtm
5 years, 11 months ago (2015-01-13 06:54:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840863003/20001
5 years, 11 months ago (2015-01-13 06:57:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-13 08:05:40 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 08:06:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e925a3b964d080423a2aef982c193139c4c4cca3
Cr-Commit-Position: refs/heads/master@{#311236}

Powered by Google App Engine
This is Rietveld 408576698