SkCachingPixelRef to use SkImageGenerator

SkCachingPixelRef to use SkImageGenerator

-   Remove SkLazyCachingPixelRef class.

-   Refactor unit tests.

BUG=
R=reed@google.com, scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12505

[hal.canary, 2013-11-22 21:07:00]

Killing off SkLazyCachingPixelRef.

[reed1, 2013-11-22 21:13:48]

lgtm -- please wait for Leon's review as well.

[scroggo, 2013-12-02 18:26:01]

https://codereview.chromium.org/84083002/diff/1/src/lazy/SkCachingPixelRef.h
File src/lazy/SkCachingPixelRef.h (right):

https://codereview.chromium.org/84083002/diff/1/src/lazy/SkCachingPixelRef.h#...
src/lazy/SkCachingPixelRef.h:29: *  This created SkCachingPixelRef will take
ownership of the
Could you say that the SkCachingPixelRef is installed on dst?

https://codereview.chromium.org/84083002/diff/1/src/lazy/SkCachingPixelRef.h#...
src/lazy/SkCachingPixelRef.h:32: static bool
Install(SkAutoTDelete<SkImageGenerator>* gen, SkBitmap* dst);
Although I understand the motivation - it simplifies things for the caller, it
seems odd to me to pass the SkImageGenerator inside an SkAutoTDelete.

If we stick with the SkAutoTDelete, can you add a comment that gen is unchanged
on failure (i.e. still holds an SkImageGenerator)?

https://codereview.chromium.org/84083002/diff/1/src/lazy/SkCachingPixelRef.h#...
src/lazy/SkCachingPixelRef.h:54: SkImageInfo       fInfo;
fInfo and fRowBytes can be const.

[hal.canary, 2013-12-04 23:06:40]

https://codereview.chromium.org/84083002/diff/1/src/lazy/SkCachingPixelRef.h
File src/lazy/SkCachingPixelRef.h (right):

https://codereview.chromium.org/84083002/diff/1/src/lazy/SkCachingPixelRef.h#...
src/lazy/SkCachingPixelRef.h:32: static bool
Install(SkAutoTDelete<SkImageGenerator>* gen, SkBitmap* dst);
On 2013/12/02 18:26:01, scroggo wrote:
> it seems odd to me to pass the SkImageGenerator inside 
> an SkAutoTDelete.


I ended up changing my mind on this.  Let's keep the interface similar to
SkDiscardablePixelRef::Install and make the comments very clear.

https://codereview.chromium.org/84083002/diff/1/src/lazy/SkCachingPixelRef.h#...
src/lazy/SkCachingPixelRef.h:54: SkImageInfo       fInfo;
On 2013/12/02 18:26:01, scroggo wrote:
> fInfo and fRowBytes can be const.

Done.

[scroggo, 2013-12-04 23:10:39]

On 2013/12/04 23:06:40, Hal Canary wrote:
> https://codereview.chromium.org/84083002/diff/1/src/lazy/SkCachingPixelRef.h
> File src/lazy/SkCachingPixelRef.h (right):
> 
>
https://codereview.chromium.org/84083002/diff/1/src/lazy/SkCachingPixelRef.h#...
> src/lazy/SkCachingPixelRef.h:32: static bool
> Install(SkAutoTDelete<SkImageGenerator>* gen, SkBitmap* dst);
> On 2013/12/02 18:26:01, scroggo wrote:
> > it seems odd to me to pass the SkImageGenerator inside 
> > an SkAutoTDelete.
> 
> 
> I ended up changing my mind on this.  Let's keep the interface similar to
> SkDiscardablePixelRef::Install and make the comments very clear.
> 
>
https://codereview.chromium.org/84083002/diff/1/src/lazy/SkCachingPixelRef.h#...
> src/lazy/SkCachingPixelRef.h:54: SkImageInfo       fInfo;
> On 2013/12/02 18:26:01, scroggo wrote:
> > fInfo and fRowBytes can be const.
> 
> Done.

lgtm

[hal.canary, 2013-12-05 14:00:10]

Committed patchset #4 manually as r12505 (presubmit successful).