Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: net/disk_cache/blockfile/file_ios.cc

Issue 840813009: Enable strict-virtual-specifiers for iOS builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/public/web_state/web_state.h ('k') | net/proxy/proxy_config_service_ios.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/blockfile/file_ios.cc
diff --git a/net/disk_cache/blockfile/file_ios.cc b/net/disk_cache/blockfile/file_ios.cc
index ef0e2fa5ca0bc74418dd7465d39acba1e2785bb0..3ffb5a585671bc32d4f6f6299f98ad709eb5ca05 100644
--- a/net/disk_cache/blockfile/file_ios.cc
+++ b/net/disk_cache/blockfile/file_ios.cc
@@ -47,7 +47,7 @@ class FileBackgroundIO : public disk_cache::BackgroundIO {
void Write();
private:
- virtual ~FileBackgroundIO() {}
+ ~FileBackgroundIO() override {}
disk_cache::FileIOCallback* callback_;
@@ -64,7 +64,7 @@ class FileBackgroundIO : public disk_cache::BackgroundIO {
class FileInFlightIO : public disk_cache::InFlightIO {
public:
FileInFlightIO() {}
- virtual ~FileInFlightIO() {}
+ ~FileInFlightIO() override {}
// These methods start an asynchronous operation. The arguments have the same
// semantics of the File asynchronous operations, with the exception that the
@@ -79,8 +79,8 @@ class FileInFlightIO : public disk_cache::InFlightIO {
// |cancel| is true if the actual task posted to the thread is still
// queued (because we are inside WaitForPendingIO), and false if said task is
// the one performing the call.
- virtual void OnOperationComplete(disk_cache::BackgroundIO* operation,
- bool cancel) override;
+ void OnOperationComplete(disk_cache::BackgroundIO* operation,
+ bool cancel) override;
private:
DISALLOW_COPY_AND_ASSIGN(FileInFlightIO);
« no previous file with comments | « ios/web/public/web_state/web_state.h ('k') | net/proxy/proxy_config_service_ios.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698