gpu: Make the log of texture binding failure more specific.

gpu: Make the log of texture binding failure more specific.

BUG=446267
Committed: https://crrev.com/7d87d723d6c855f064932883cc38ef08ff91b2b6
Cr-Commit-Position: refs/heads/master@{#311536}

[dshwang, 2015-01-13 11:56:40]

dongseong.hwang@intel.com changed reviewers:
+ piman@chromium.org, sievers@chromium.org

[dshwang, 2015-01-13 11:56:41]

could you review?

When reading Issue 446267, the texture binding failure log is so broad. I want
to know which reason causes this failure; npot or failure to create texture.
[16713:16713:0104/003351:ERROR:gles2_cmd_decoder.cc(6249)] :
[.Compositor-0x287db44b5900]RENDER WARNING: texture bound to texture unit 0 is
not renderable. It maybe non-power-of-2 and have incompatible texture filtering
or is not 'texture complete'

[no sievers, 2015-01-13 20:21:01]

https://codereview.chromium.org/840763003/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/840763003/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6432: std::string("texture bound
to texture unit ") +
Isn't it rather that there is no texture bound to the unit?

https://codereview.chromium.org/840763003/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6440: " incompatible texture
filtering");
and if it's not renderable it could also be because it's not complete?

[dshwang, 2015-01-14 14:41:55]

https://codereview.chromium.org/840763003/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/840763003/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6432: std::string("texture bound
to texture unit ") +
On 2015/01/13 20:21:01, sievers wrote:
> Isn't it rather that there is no texture bound to the unit?

Done.

https://codereview.chromium.org/840763003/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6440: " incompatible texture
filtering");
On 2015/01/13 20:21:01, sievers wrote:
> and if it's not renderable it could also be because it's not complete?

Yes, I think that "not renderable" is same meaning to "not complete". I removed
"not complete" term in the log.

[no sievers, 2015-01-14 19:21:11]

lgtm

[dshwang, 2015-01-14 19:57:57]

On 2015/01/14 19:21:11, sievers wrote:
> lgtm

thx for reviewing!

[dshwang, 2015-01-14 19:57:59]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2015-01-14 19:59:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/840763003/20001

[commit-bot: I haz the power, 2015-01-14 20:03:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-14 20:04:13]

Patchset 2 (id:??) landed as
https://crrev.com/7d87d723d6c855f064932883cc38ef08ff91b2b6
Cr-Commit-Position: refs/heads/master@{#311536}