Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 840733004: Replace setCompositeOperation(CompositeOperator, WebBlendMode) with setCompositeOperation(SkXfermod… (Closed)

Created:
5 years, 11 months ago by dshwang
Modified:
5 years, 11 months ago
CC:
blink-reviews, eae+blinkwatch, fs, eric.carlson_apple.com, aandrey+blink_chromium.org, rwlbuis, krit, blink-reviews-html_chromium.org, danakj, dglazkov+blink, Rik, jchaffraix+rendering, blink-reviews-paint_chromium.org, pdr+svgwatchlist_chromium.org, zoltan1, philipj_slow, jbroman, Dominik Röttsches, feature-media-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, gyuyoung.kim_webkit.org, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, kouhei+svg_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace setCompositeOperation(CompositeOperator, WebBlendMode) with setCompositeOperation(SkXfermode::Mode) BUG=425656 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188759

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename compositeOperationDeprecated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -56 lines) Patch
M Source/core/html/HTMLVideoElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/BoxPainter.cpp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/LayerPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/ViewPainter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/CrossfadeGeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GradientGeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 1 2 chunks +6 lines, -7 lines 0 comments Download
M Source/platform/graphics/GraphicsContextTest.cpp View 15 chunks +23 lines, -23 lines 0 comments Download
M Source/platform/graphics/Image.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/paint/CompositingDisplayItem.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
dshwang
could you review? I'm removing GraphicsContext dependency on CompositeOperator and WebBlendMode incrementally.
5 years, 11 months ago (2015-01-21 16:16:39 UTC) #2
dshwang
https://codereview.chromium.org/840733004/diff/1/Source/platform/graphics/GraphicsContext.h File Source/platform/graphics/GraphicsContext.h (right): https://codereview.chromium.org/840733004/diff/1/Source/platform/graphics/GraphicsContext.h#newcode184 Source/platform/graphics/GraphicsContext.h:184: CompositeOperator compositeOperator() const; change this method name to avoid ...
5 years, 11 months ago (2015-01-21 16:18:11 UTC) #3
Justin Novosad
https://codereview.chromium.org/840733004/diff/1/Source/platform/graphics/GraphicsContext.h File Source/platform/graphics/GraphicsContext.h (right): https://codereview.chromium.org/840733004/diff/1/Source/platform/graphics/GraphicsContext.h#newcode184 Source/platform/graphics/GraphicsContext.h:184: CompositeOperator compositeOperator() const; On 2015/01/21 16:18:11, dshwang wrote: > ...
5 years, 11 months ago (2015-01-21 16:44:01 UTC) #4
dshwang
On 2015/01/21 16:44:01, junov wrote: > https://codereview.chromium.org/840733004/diff/1/Source/platform/graphics/GraphicsContext.h > File Source/platform/graphics/GraphicsContext.h (right): > > https://codereview.chromium.org/840733004/diff/1/Source/platform/graphics/GraphicsContext.h#newcode184 > ...
5 years, 11 months ago (2015-01-21 17:39:07 UTC) #5
Justin Novosad
lgtm
5 years, 11 months ago (2015-01-21 18:44:58 UTC) #6
dshwang
On 2015/01/21 18:44:58, junov wrote: > lgtm thx for reviewing!
5 years, 11 months ago (2015-01-21 18:50:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840733004/20001
5 years, 11 months ago (2015-01-21 18:50:29 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 18:54:38 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188759

Powered by Google App Engine
This is Rietveld 408576698