Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 840733002: Properly create a new profile when the last non-supervised profile is deleted (Closed)

Created:
5 years, 11 months ago by Marc Treib
Modified:
5 years, 11 months ago
Reviewers:
noms (inactive)
CC:
chromium-reviews, rginda+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly create a new profile when the last non-supervised profile is deleted (even when it's not the current profile that's being deleted). BUG=445043 Committed: https://crrev.com/ff3b4402237d177cc1cc57f8e44824dc3b2bd23a Cr-Commit-Position: refs/heads/master@{#310751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -39 lines) Patch
M chrome/browser/profiles/profile_manager.cc View 1 chunk +41 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Marc Treib
PTAL!
5 years, 11 months ago (2015-01-07 10:45:37 UTC) #2
noms (inactive)
lgtm. This should only be different for supervised users, right? If you're deleting a normal, ...
5 years, 11 months ago (2015-01-08 21:13:22 UTC) #3
Marc Treib
On 2015/01/08 21:13:22, Monica Dinculescu wrote: > lgtm. > > This should only be different ...
5 years, 11 months ago (2015-01-09 10:13:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840733002/1
5 years, 11 months ago (2015-01-09 10:14:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 10:53:35 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 10:54:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff3b4402237d177cc1cc57f8e44824dc3b2bd23a
Cr-Commit-Position: refs/heads/master@{#310751}

Powered by Google App Engine
This is Rietveld 408576698