Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 840673002: Revert of Use Surfaces on Windows, Linux, and Mac OS (try #3) (Closed)

Created:
5 years, 11 months ago by jbauman
Modified:
5 years, 11 months ago
Reviewers:
CC:
chromium-reviews, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use Surfaces on Windows, Linux, and Mac OS (try #3) (patchset #1 id:1 of https://codereview.chromium.org/786243003/) Reason for revert: May be causing some browser_tests to flake: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34159 http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34157 http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34156 http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34152 http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34150 http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34149 Original issue's description: > Use Surfaces on Windows, Linux, and Mac OS (try #3) > > Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet. > > BUG=334090 > TBR=piman@chromium.org > > Committed: https://crrev.com/7fa9d3f715573c22081f11238a4ccf44bc0efb19 > Cr-Commit-Position: refs/heads/master@{#309998} TBR= NOTREECHECKS=true NOTRY=true BUG=334090 Committed: https://crrev.com/83a817493be1a4d7bc1b1fd7941df0157dc6106f Cr-Commit-Position: refs/heads/master@{#310186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 chunk +6 lines, -13 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbauman
Created Revert of Use Surfaces on Windows, Linux, and Mac OS (try #3)
5 years, 11 months ago (2015-01-07 00:24:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840673002/1
5 years, 11 months ago (2015-01-07 00:25:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 00:27:31 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 00:29:02 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83a817493be1a4d7bc1b1fd7941df0157dc6106f
Cr-Commit-Position: refs/heads/master@{#310186}

Powered by Google App Engine
This is Rietveld 408576698