Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 840653002: SkPDFImage no longer caches a unpremul version of N32 bitmaps. (Closed)

Created:
5 years, 11 months ago by hal.canary
Modified:
5 years, 11 months ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDFImage no longer caches a unpremul version of N32 bitmaps. This reduces PDF memory overhead by 30% over all GMs. This reduces PDF memory overhead by 41% over all SKPs in chromium-skia-gm/playback_${SKP_VERSION}/skps. BUG=skia:3030 Committed: https://skia.googlesource.com/skia/+/549f879d6a8c420fb510491fe49f2618bb0ba2c3

Patch Set 1 #

Patch Set 2 : simpler CL #

Total comments: 1

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -21 lines) Patch
M src/pdf/SkPDFImage.cpp View 1 2 3 chunks +49 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hal.canary
ptal
5 years, 11 months ago (2015-01-06 22:36:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840653002/1
5 years, 11 months ago (2015-01-06 22:38:31 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-06 22:38:32 UTC) #5
hal.canary
PTAL at the simplified CL
5 years, 11 months ago (2015-01-08 18:18:52 UTC) #7
reed1
lgtm w/ request for comment https://codereview.chromium.org/840653002/diff/20001/src/pdf/SkPDFImage.cpp File src/pdf/SkPDFImage.cpp (right): https://codereview.chromium.org/840653002/diff/20001/src/pdf/SkPDFImage.cpp#newcode163 src/pdf/SkPDFImage.cpp:163: c = get_argb8888_neighbor_avg_color(bitmap, x, ...
5 years, 11 months ago (2015-01-08 18:29:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840653002/40001
5 years, 11 months ago (2015-01-08 18:57:20 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 19:05:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/549f879d6a8c420fb510491fe49f2618bb0ba2c3

Powered by Google App Engine
This is Rietveld 408576698