Restructure sandbox code to reduce dependencies pulled in by intercept code.

sandbox/win/src/service_resolver.cc

Index: sandbox/win/src/service_resolver.cc
diff --git a/sandbox/win/src/service_resolver.cc b/sandbox/win/src/service_resolver.cc
index bae698c4576d7672ba7f370b1a9223400beb557b..791fecc8bae1fd11a535e7976e430036857974fb 100644
--- a/sandbox/win/src/service_resolver.cc
+++ b/sandbox/win/src/service_resolver.cc
@@ -1,11 +1,11 @@
-// Copyright (c) 2006-2010 The Chromium Authors. All rights reserved.
+// Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/win/src/service_resolver.h"
 
-#include "base/logging.h"
 #include "base/win/pe_image.h"
+#include "sandbox/win/src/sandbox_nt_util.h"
 
 namespace sandbox {
 
@@ -24,7 +24,6 @@ NTSTATUS ServiceResolverThunk::ResolveInterceptor(
 NTSTATUS ServiceResolverThunk::ResolveTarget(const void* module,
                                              const char* function_name,
                                              void** address) {
-  DCHECK(address);
   if (NULL == module)
     return STATUS_UNSUCCESSFUL;
 
@@ -32,11 +31,15 @@ NTSTATUS ServiceResolverThunk::ResolveTarget(const void* module,
   *address = module_image.GetProcAddress(function_name);
 
   if (NULL == *address) {
-    NOTREACHED();
+    NOTREACHED_NT();
     return STATUS_UNSUCCESSFUL;
   }
 
   return STATUS_SUCCESS;
 }
 
+void ServiceResolverThunk::AllowLocalPatches() {
+  ntdll_base_ = ::GetModuleHandle(L"ntdll.dll");

[cpu_(ooo_6.6-7.5), 2013/11/29 18:30:07]

don't we have a constant for "ntdll.dll"? if it is too cumbersome we can leave
it as is.

Btw, I believe that (contrary to most of win32) the loader functions that take
strings are natively single byte strings (ansi?) so calling GetModuleHandleA is
better.

[robertshield, 2013/11/29 19:29:08]

There's a wide version of kNtdllName in internal_types.h, no ansi one. How about
I leave the string here and call GetModuleA?

[cpu_(ooo_6.6-7.5), 2013/12/01 00:18:44]

Either fix sgtm.

+}
+
 }  // namespace sandbox