chrome/browser/ui/sync/one_click_signin_helper.cc - Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding better comment from Charlie. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper.h ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_helper.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc

index c210405fbe14c81ea34a1ea715827cbb05b19c4a..94b1de39a386b4adda1f393f88c3dc557adc2cd8 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc

@@ -1099,10 +1099,11 @@ void OneClickSigninHelper::set_do_not_start_sync_for_testing() {

do_not_start_sync_for_testing_ = true;

}

-void OneClickSigninHelper::NavigateToPendingEntry(

+void OneClickSigninHelper::DidStartNavigationToPendingEntry(

const GURL& url,

content::NavigationController::ReloadType reload_type) {

- VLOG(1) << "OneClickSigninHelper::NavigateToPendingEntry: url=" << url.spec();

+ VLOG(1) << "OneClickSigninHelper::DidStartNavigationToPendingEntry: url=" <<

+ url.spec();

// If the tab navigates to a new page, and this page is not a valid Gaia

// sign in redirect or reponse, or the expected continue URL, make sure to

// clear the internal state. This is needed to detect navigations in the