content/browser/web_contents/web_contents_impl_browsertest.cc - Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_browsertest.cc

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl_browsertest.cc

diff --git a/content/browser/web_contents/web_contents_impl_browsertest.cc b/content/browser/web_contents/web_contents_impl_browsertest.cc

index 48cba05f8f4591e2276966a44876c980c2218024..fba71123deeac64c1e391abd6dac8c1902ec1cc7 100644

--- a/content/browser/web_contents/web_contents_impl_browsertest.cc

+++ b/content/browser/web_contents/web_contents_impl_browsertest.cc

@@ -135,7 +135,7 @@ class RenderViewSizeObserver : public WebContentsObserver {

rwhv_create_size_ = rvh->GetView()->GetViewBounds().size();

}

- virtual void NavigateToPendingEntry(

+ virtual void DidCreatePendingEntry(

const GURL& url,

NavigationController::ReloadType reload_type) OVERRIDE {

ResizeWebContentsView(shell_, wcv_new_size_, false);

@@ -288,7 +288,7 @@ IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest,

// RenderWidgetHostView is created at specified size.

init_size.Enlarge(size_insets.width(), size_insets.height());

EXPECT_EQ(init_size, observer.rwhv_create_size());

- // RenderViewSizeObserver resizes WebContentsView in NavigateToPendingEntry,

+ // RenderViewSizeObserver resizes WebContentsView in DidCreatePendingEntry,

// so both WebContentsView and RenderWidgetHostView adopt this new size.

new_size.Enlarge(size_insets.width(), size_insets.height());

EXPECT_EQ(new_size,