chrome/browser/ui/browser_browsertest.cc - Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/predictor_tab_helper.cc ('k') | chrome/browser/ui/browser_instant_controller_unittest.cc » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_browsertest.cc

diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc

index aba8e8da4144695286229d967bdff63271bb2e09..893cc246f3b5eafcc830916ccec63d15855eabec 100644

--- a/chrome/browser/ui/browser_browsertest.cc

+++ b/chrome/browser/ui/browser_browsertest.cc

@@ -278,7 +278,7 @@ class RenderViewSizeObserver : public content::WebContentsObserver {

// Enlarge WebContentsView by |wcv_resize_insets_| while the navigation entry

// is pending.

- virtual void NavigateToPendingEntry(

+ virtual void DidCreatePendingEntry(

const GURL& url,

NavigationController::ReloadType reload_type) OVERRIDE {

if (wcv_resize_insets_.IsEmpty())

@@ -319,7 +319,7 @@ class RenderViewSizeObserver : public content::WebContentsObserver {

typedef std::map<content::RenderViewHost*, Sizes> RenderViewSizes;

RenderViewSizes render_view_sizes_;

- // Enlarge WebContentsView by this size insets in NavigateToPendingEntry.

+ // Enlarge WebContentsView by this size insets in DidCreatePendingEntry.

gfx::Size wcv_resize_insets_;

BrowserWindow* browser_window_; // Weak ptr.

@@ -2544,7 +2544,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, DISABLED_GetSizeForNewRenderView) {

initial_wcv_size.height() + height_inset),

rwhv_create_size2);

// WebContentsView was resized in

- // RenderViewSizeObserver::NavigateToPendingEntry after RenderWidgetHostView

+ // RenderViewSizeObserver::DidCreatePendingEntry after RenderWidgetHostView

// was created, so the commit size should be resized accordingly.

gfx::Size exp_commit_size(initial_wcv_size);

exp_commit_size.Enlarge(wcv_resize_insets.width(),