Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.h

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding better comment from Charlie. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_SETTINGS_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_SETTINGS_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_SETTINGS_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_SETTINGS_HANDLER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 88
89 void GetLocalizedValues(content::WebUIDataSource* source); 89 void GetLocalizedValues(content::WebUIDataSource* source);
90 90
91 private: 91 private:
92 friend class ExtensionUITest; 92 friend class ExtensionUITest;
93 friend class BrokerDelegate; 93 friend class BrokerDelegate;
94 94
95 // content::WebContentsObserver implementation. 95 // content::WebContentsObserver implementation.
96 virtual void RenderViewDeleted( 96 virtual void RenderViewDeleted(
97 content::RenderViewHost* render_view_host) OVERRIDE; 97 content::RenderViewHost* render_view_host) OVERRIDE;
98 virtual void NavigateToPendingEntry( 98 virtual void DidStartNavigationToPendingEntry(
99 const GURL& url, 99 const GURL& url,
100 content::NavigationController::ReloadType reload_type) OVERRIDE; 100 content::NavigationController::ReloadType reload_type) OVERRIDE;
101 101
102 // Allows injection for testing by friend classes. 102 // Allows injection for testing by friend classes.
103 ExtensionSettingsHandler(ExtensionService* service, 103 ExtensionSettingsHandler(ExtensionService* service,
104 ManagementPolicy* policy); 104 ManagementPolicy* policy);
105 105
106 // WebUIMessageHandler implementation. 106 // WebUIMessageHandler implementation.
107 virtual void RegisterMessages() OVERRIDE; 107 virtual void RegisterMessages() OVERRIDE;
108 108
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 269
270 // An observer to listen for when Extension errors are reported. 270 // An observer to listen for when Extension errors are reported.
271 ScopedObserver<ErrorConsole, ErrorConsole::Observer> error_console_observer_; 271 ScopedObserver<ErrorConsole, ErrorConsole::Observer> error_console_observer_;
272 272
273 DISALLOW_COPY_AND_ASSIGN(ExtensionSettingsHandler); 273 DISALLOW_COPY_AND_ASSIGN(ExtensionSettingsHandler);
274 }; 274 };
275 275
276 } // namespace extensions 276 } // namespace extensions
277 277
278 #endif // CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_SETTINGS_HANDLER_H_ 278 #endif // CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_SETTINGS_HANDLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698