Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/ui/sync/one_click_signin_helper.h

Issue 84063003: Rename WebContentsObserver::NavigateToPendingEntry to DidStartNavigationToPendingEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding better comment from Charlie. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_ 5 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
6 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_ 6 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 // TestingProfile provides. 219 // TestingProfile provides.
220 void SetDoNotClearPendingEmailForTesting(); 220 void SetDoNotClearPendingEmailForTesting();
221 221
222 // In unit tests, disable starting the actual sync. 222 // In unit tests, disable starting the actual sync.
223 void set_do_not_start_sync_for_testing(); 223 void set_do_not_start_sync_for_testing();
224 224
225 // Called when password has been submitted. 225 // Called when password has been submitted.
226 void PasswordSubmitted(const autofill::PasswordForm& form); 226 void PasswordSubmitted(const autofill::PasswordForm& form);
227 227
228 // content::WebContentsObserver overrides. 228 // content::WebContentsObserver overrides.
229 virtual void NavigateToPendingEntry( 229 virtual void DidStartNavigationToPendingEntry(
230 const GURL& url, 230 const GURL& url,
231 content::NavigationController::ReloadType reload_type) OVERRIDE; 231 content::NavigationController::ReloadType reload_type) OVERRIDE;
232 virtual void DidNavigateMainFrame( 232 virtual void DidNavigateMainFrame(
233 const content::LoadCommittedDetails& details, 233 const content::LoadCommittedDetails& details,
234 const content::FrameNavigateParams& params) OVERRIDE; 234 const content::FrameNavigateParams& params) OVERRIDE;
235 virtual void DidStopLoading( 235 virtual void DidStopLoading(
236 content::RenderViewHost* render_view_host) OVERRIDE; 236 content::RenderViewHost* render_view_host) OVERRIDE;
237 virtual void WebContentsDestroyed(content::WebContents* contents) OVERRIDE; 237 virtual void WebContentsDestroyed(content::WebContents* contents) OVERRIDE;
238 238
239 // ProfileSyncServiceObserver. 239 // ProfileSyncServiceObserver.
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 281
282 // Allows unittest to avoid starting sync for real. 282 // Allows unittest to avoid starting sync for real.
283 bool do_not_start_sync_for_testing_; 283 bool do_not_start_sync_for_testing_;
284 284
285 base::WeakPtrFactory<OneClickSigninHelper> weak_pointer_factory_; 285 base::WeakPtrFactory<OneClickSigninHelper> weak_pointer_factory_;
286 286
287 DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelper); 287 DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelper);
288 }; 288 };
289 289
290 #endif // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_ 290 #endif // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_navigation_observer.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698