Issue 840573002: Revert of use conics for ovals and roundrects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 840573002: Revert of use conics for ovals and roundrects (Closed)

Created:
5 years, 11 months ago by reed1

Modified:
5 years, 11 months ago

Reviewers:
reed2

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of use conics for ovals and roundrects (patchset #1 id:1 of https://codereview.chromium.org/817283005/) Reason for revert: need fix in edgebuilder+aa Original issue's description: > use conics for ovals and roundrects > > adapted from https://codereview.chromium.org/831313002/ > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/2bf1c4d58b84c73c6421edcb25e3afb4971da200 TBR=reed@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/e3b61eb7997d12c5f9b844dd3af1847492d9f411

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -90 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 chunk	+0 lines, -84 lines	0 comments	Download
M	gyp/skia_for_android_framework_defines.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	gyp/skia_for_chromium_defines.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/core/SkPath.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pathops/SkOpEdgeBuilder.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840573002/1

5 years, 11 months ago (2015-01-06 15:13:36 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-06 15:17:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e3b61eb7997d12c5f9b844dd3af1847492d9f411