Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

Issue 840563005: dart2js: Use is-checks from the model in the old emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
index 0b9666e5c73b7c1891106611687a6ce3b073b513..57974bf5e14c8d852da506dbd2b883261a0ee306 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart
@@ -46,7 +46,7 @@ class ClassEmitter extends CodeEmitterHelper {
emitClassGettersSettersForCSP(classElement, builder,
onlyForRti: onlyForRti);
emitInstanceMembers(classElement, builder, onlyForRti: onlyForRti);
- emitter.typeTestEmitter.emitIsTests(classElement, builder);
+ emitRuntimeTypeInformation(cls, builder);
if (additionalProperties != null) {
additionalProperties.forEach(builder.addProperty);
}
@@ -306,6 +306,18 @@ class ClassEmitter extends CodeEmitterHelper {
}
}
+ /// Emits the members from the model.
+ void emitRuntimeTypeInformation(Class cls, ClassBuilder builder) {
+ assert(builder.functionType == null);
+ if (cls.functionTypeIndex != null) {
+ builder.functionType = '${cls.functionTypeIndex}';
+ }
+
+ for (Method method in cls.isChecks) {
+ builder.addProperty(method.name, method.code);
+ }
+ }
+
void emitClassBuilderWithReflectionData(String className,
ClassElement classElement,
ClassBuilder classBuilder,

Powered by Google App Engine
This is Rietveld 408576698